Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support molecule import statement #648

Merged
merged 4 commits into from
Mar 11, 2024
Merged

feat: support molecule import statement #648

merged 4 commits into from
Mar 11, 2024

Conversation

homura
Copy link
Collaborator

@homura homura commented Mar 8, 2024

Description

Fixes #643

This PR supports the import statement of Molecule but with a bit different from the design of #643. This PR supports codegen recursively for the pattern of **/*.mol in a directory instead of an entry file

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • unit test
  • test manually

Copy link

vercel bot commented Mar 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lumos-website ✅ Ready (Inspect) Visit Preview Mar 8, 2024 11:35am

@homura homura self-assigned this Mar 8, 2024
@homura homura requested a review from PainterPuppets March 8, 2024 11:06
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 98.65471% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 84.30%. Comparing base (b6a3229) to head (0b98aaa).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #648      +/-   ##
===========================================
+ Coverage    84.17%   84.30%   +0.12%     
===========================================
  Files          120      121       +1     
  Lines        24357    24574     +217     
  Branches      2341     2364      +23     
===========================================
+ Hits         20503    20717     +214     
- Misses        3813     3816       +3     
  Partials        41       41              
Files Coverage Δ
packages/molecule/src/topologySort.ts 100.00% <100.00%> (ø)
packages/molecule/src/codegen.ts 96.75% <98.11%> (+0.79%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6a3229...0b98aaa. Read the comment docs.

@homura homura mentioned this pull request Mar 8, 2024
4 tasks
@homura homura marked this pull request as ready for review March 8, 2024 11:21
Copy link
Contributor

@PainterPuppets PainterPuppets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

packages/molecule/src/cli.ts Show resolved Hide resolved
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it is not a circular dependency if the file d doesn't import either 'b' or 'c'.

@homura homura merged commit f2fbef5 into develop Mar 11, 2024
9 checks passed
@homura homura deleted the mol-stmt-import branch March 11, 2024 09:14
@homura homura mentioned this pull request Mar 12, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support the import statement of molecule for the codegen
2 participants