-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support molecule import statement #648
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #648 +/- ##
===========================================
+ Coverage 84.17% 84.30% +0.12%
===========================================
Files 120 121 +1
Lines 24357 24574 +217
Branches 2341 2364 +23
===========================================
+ Hits 20503 20717 +214
- Misses 3813 3816 +3
Partials 41 41
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose it is not a circular dependency if the file d
doesn't import either 'b' or 'c'.
Description
Fixes #643
This PR supports the import statement of Molecule but with a bit different from the design of #643. This PR supports codegen recursively for the pattern of
**/*.mol
in a directory instead of an entry fileType of change
Please delete options that are not relevant.
How Has This Been Tested?