-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: codegen for molecule #635
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #635 +/- ##
===========================================
- Coverage 87.06% 84.17% -2.89%
===========================================
Files 118 120 +2
Lines 24049 24356 +307
Branches 2442 2341 -101
===========================================
- Hits 20938 20502 -436
- Misses 3068 3813 +745
+ Partials 43 41 -2
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
The first version of the codegen doesn't support the import statement of Molecule yet. To deal with the cases of importing other schemas, the codegen CLI also needs to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work!
It seems that cli can only read schemaFile
from config file, it would be better if it supports setting by args
.
Exactly, we can make the CLI easier to use later |
Description
Fixes #630
This PR introduces a cli
lumos-molecule-codegen
to generate code from molecule schemas.Currently, there are some limitations of this codegen, such as
Molecule import statement
is not supported yetType of change
Please delete options that are not relevant.
How Has This Been Tested?