-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: supported bitcoin auth in omnilock #607
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #607 +/- ##
===========================================
+ Coverage 87.04% 87.29% +0.25%
===========================================
Files 117 118 +1
Lines 23782 23983 +201
Branches 2416 2459 +43
===========================================
+ Hits 20701 20936 +235
+ Misses 3039 3005 -34
Partials 42 42
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
export function decodeAddress(address: string): ArrayLike<number> { | ||
try { | ||
// Bech32 | ||
if (address.startsWith("bc1")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both Native Segwit and Taproot addresses start with bc1
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the taproot address is encoded via bech32m so it will fail when trying to decode via bech32, the following catch block will throw an error to tell the user that the p2tr is not supported yet
Hold on, a new concept "display message" comes to Omnilock that prepends a human-readable prefix before the transaction digest, like |
# Conflicts: # packages/common-scripts/package.json
Description
Fixes #604
This PR supported Bitcoin auth in Omnilock
Example
Type of change
How Has This Been Tested?