Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate config/helpers and fix website address conversion #606

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

homura
Copy link
Collaborator

@homura homura commented Jan 11, 2024

Description

This PR

  1. deprecated the submodule helpers in @ckb-lumos/lumos/config and @ckb-lumos/config-manager to avoid confusion with @ckb-lumos/helpers
  2. fixed the address conversion
import { helpers } from '@ckb-lumos/lumos/config' // Not Recommended
import { helpers } from '@ckb-lumos/config-manager' // Not Recommended
import { nameOfScript } from '@ckb-lumos/lumos/config' // Recommended

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Copy link

vercel bot commented Jan 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lumos-website ✅ Ready (Inspect) Visit Preview Jan 11, 2024 4:53am

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7e89b4a) 83.86% compared to head (e066038) 87.19%.
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #606      +/-   ##
===========================================
+ Coverage    83.86%   87.19%   +3.32%     
===========================================
  Files          116      116              
  Lines        23598    23602       +4     
  Branches      2225     2417     +192     
===========================================
+ Hits         19790    20579     +789     
+ Misses        3768     2978     -790     
- Partials        40       45       +5     
Files Coverage Δ
packages/config-manager/src/index.ts 100.00% <100.00%> (ø)
packages/config-manager/src/predefined.ts 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dadced8...e066038. Read the comment docs.

@homura homura changed the title fix(website): inccorect address conversion feat: deprecate config/helpers and fix website address conversion Jan 11, 2024
@homura homura merged commit 349be74 into develop Jan 11, 2024
9 checks passed
@homura homura deleted the website-address branch January 11, 2024 04:55
@github-actions github-actions bot mentioned this pull request Jan 11, 2024
@github-actions github-actions bot mentioned this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants