Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: make @ckb-lumos/lumos more convenient #588

Merged
merged 19 commits into from
Dec 20, 2023
Merged

Conversation

homura
Copy link
Collaborator

@homura homura commented Dec 16, 2023

Description

Resolves #585

Go to the migration for more details

Type of change

  • Refactor (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation or Website
  • Example

How Has This Been Tested?

Copy link

vercel bot commented Dec 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lumos-website ✅ Ready (Inspect) Visit Preview Dec 20, 2023 2:44am

Copy link

codecov bot commented Dec 16, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6940207) 83.85% compared to head (235810e) 87.18%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #588      +/-   ##
===========================================
+ Coverage    83.85%   87.18%   +3.32%     
===========================================
  Files          116      116              
  Lines        23577    23583       +6     
  Branches      2221     2415     +194     
===========================================
+ Hits         19771    20561     +790     
+ Misses        3766     2984     -782     
+ Partials        40       38       -2     
Files Coverage Δ
packages/base/src/blockchain.ts 98.39% <100.00%> (+<0.01%) ⬆️
packages/base/src/utils.ts 73.40% <100.00%> (-0.92%) ⬇️
packages/codec/src/base.ts 100.00% <100.00%> (ø)
packages/config-manager/src/manager.ts 79.36% <0.00%> (ø)

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6940207...235810e. Read the comment docs.

@homura homura changed the title feat(base): add BytesOptVec into blockchain refactor: make the entry package @ckb-lumos/lumos more convenient Dec 16, 2023
@homura homura changed the title refactor: make the entry package @ckb-lumos/lumos more convenient refactor!: make the entry package @ckb-lumos/lumos more convenient Dec 16, 2023
@homura
Copy link
Collaborator Author

homura commented Dec 19, 2023

@zhangyouxin can you help to check this PR?

@homura homura merged commit 00c3035 into develop Dec 20, 2023
9 checks passed
@homura homura changed the title refactor!: make the entry package @ckb-lumos/lumos more convenient refactor!: make @ckb-lumos/lumos more convenient Dec 20, 2023
@homura homura deleted the new-entry-pkg branch December 20, 2023 02:51
@github-actions github-actions bot mentioned this pull request Dec 20, 2023
@github-actions github-actions bot mentioned this pull request Mar 12, 2024
@homura homura mentioned this pull request Mar 12, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too many packages need to upgrade after lumos upgrading
3 participants