Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rpc): abort-controller is not a constructor in browsers #583

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

homura
Copy link
Collaborator

@homura homura commented Dec 11, 2023

Description

This PR fixes _abortController.AbortController is not a constructor while running lumos in browsers because the export behavior in abort-controller is not the same between browser and node.

Related pieces

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

git clone https://github.com/ckb-js/lumos.git
cd lumos
git checkout abort-controller-not-found
pnpm install
npm run clean
npm run build
cd examples/omni-lock-secp256k1-blake160
pnpm install
npm start

Copy link

vercel bot commented Dec 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lumos-website ✅ Ready (Inspect) Visit Preview Dec 11, 2023 4:59am

@homura homura requested a review from zhangyouxin December 11, 2023 05:06
@homura homura merged commit ef5d099 into develop Dec 11, 2023
8 of 9 checks passed
@homura homura deleted the abort-controller-not-found branch December 11, 2023 06:33
@github-actions github-actions bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants