Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): make fetch customizable #574

Merged
merged 4 commits into from
Nov 27, 2023
Merged

feat(rpc): make fetch customizable #574

merged 4 commits into from
Nov 27, 2023

Conversation

homura
Copy link
Collaborator

@homura homura commented Nov 27, 2023

Description

Fixes #573

This PR makes the fetch in the @ckb-lumos/rpc become customizable

Type of change

Please delete options that are not relevant.

  • [x New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • unit test

@homura homura requested a review from zhangyouxin November 27, 2023 06:54
Copy link

vercel bot commented Nov 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lumos-website ✅ Ready (Inspect) Visit Preview Nov 27, 2023 8:43am

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #574 (48fbe3c) into develop (68e4f5b) will increase coverage by 0.80%.
The diff coverage is 76.92%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #574      +/-   ##
===========================================
+ Coverage    85.88%   86.69%   +0.80%     
===========================================
  Files          116      116              
  Lines        23429    23434       +5     
  Branches      2297     2343      +46     
===========================================
+ Hits         20122    20315     +193     
+ Misses        3267     3077     -190     
- Partials        40       42       +2     
Files Coverage Δ
packages/rpc/src/method.ts 85.71% <100.00%> (+0.32%) ⬆️
packages/rpc/src/index.ts 75.41% <53.84%> (+0.98%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68e4f5b...48fbe3c. Read the comment docs.

@homura homura merged commit ce8eead into develop Nov 27, 2023
8 of 9 checks passed
@github-actions github-actions bot mentioned this pull request Nov 27, 2023
@homura homura deleted the customizable-agent branch May 9, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the httpClient in rpc module customizable
2 participants