refactor: remove peerDependency of toolkit #559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- lumos dependencies and modules are really a bit much - contributors often depend on yarn's auto-hoist to cause some module to not be installed correctlly
the docker is no longer needed
# Conflicts: # packages/ckb-indexer/package.json # packages/common-scripts/package.json # packages/debugger/package.json # packages/e2e-test/package.json # packages/experiment-tx-assembler/package.json # packages/hd-cache/package.json # packages/helpers/package.json # packages/transaction-manager/package.json
# Conflicts: # packages/testkit/package.json
# Conflicts: # packages/testkit/package.json
# Conflicts: # packages/transaction-manager/examples/chained-transfer-example/package.json
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## ckb2023 #559 +/- ##
===========================================
+ Coverage 86.53% 86.83% +0.30%
===========================================
Files 115 115
Lines 23341 23341
Branches 2331 2353 +22
===========================================
+ Hits 20197 20268 +71
+ Misses 3102 3031 -71
Partials 42 42
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
35 tasks
|
This PR is not specific to the |
|
Close reason: will change base to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
peerDependencyoftoolkitpackageType of change
How Has This Been Tested?
NormalizersusingnormalizeHexNumberworks