feat(codec): throw when duplicated ids are found

ckb-js · Dec 13, 2023 · 04f5146 · 04f5146
1 parent c677c67
commit 04f5146
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/packages/codec/src/molecule/layout.ts b/packages/codec/src/molecule/layout.ts
@@ -338,6 +338,14 @@ export function union<T extends Record<string, BytesCodec>>(
 ): UnionCodec<T> {
   checkShape(itemCodec, Array.isArray(fields) ? fields : Object.keys(fields));
 
+  // check duplicated id
+  if (!Array.isArray(fields)) {
+    const ids = Object.values(fields);
+    if (ids.length !== new Set(ids).size) {
+      throw new Error(`Duplicated id in union: ${ids.join(", ")}`);
+    }
+  }
+
   return createBytesCodec({
     pack(obj) {
       const availableFields: (keyof T)[] = Object.keys(itemCodec);

diff --git a/packages/codec/tests/molecule.test.ts b/packages/codec/tests/molecule.test.ts
@@ -229,6 +229,10 @@ test("test union with custom id", (t) => {
   ]));
 });
 
+test("test union with duplicated custom id", (t) => {
+  t.throws(() => union({ key1: Uint8, key2: Uint32LE }, { key1: 0, key2: 0 }));
+});
+
 test("test byteOf", (t) => {
   t.deepEqual(byteOf(Uint8).pack(1), bytify([1]));
   t.throws(() => byteOf(Uint16).pack(1));