Delete feed feature #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will try to look at this soon, thanks again for your contributions. |
Funami580
force-pushed
the
delete-feed-feature
branch
from
f8f0b65 to
097ff67
Compare
ckampfe
reviewed
Mar 1, 2022
|
Sorry for the delayed review. Thank you again for the contribution @Funami580. Overall I think I like this. I personally have not needed to delete feeds that often, and when I have, I usually just go into the database and do it with sql, but I believe this will be very helpful for users who are not as comfortable with sql. If you wouldn't mind adapting the one commented section to occur in a single transaction, I will test and merge. Thank you! |
Funami580
force-pushed
the
delete-feed-feature
branch
from
097ff67 to
3dad6f2
Compare
|
Ok, done. Should be ready to test. |
|
@Funami580 this is great, thank you again for your contributions, merging now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something like this?