-
Notifications
You must be signed in to change notification settings - Fork 20
Include node headers as system headers #37
base: dev
Are you sure you want to change the base?
Conversation
This will avoid problems were GCC/clang might trigger useless warnings induced by including the `v8` header.
This can be removed after cjntaylor/node-cmake#37 is merged and released.
This can be removed after cjntaylor/node-cmake#37 is merged and released.
This can be removed after cjntaylor/node-cmake#37 is merged and released.
This can be removed after cjntaylor/node-cmake#37 is merged and released.
This can be removed after cjntaylor/node-cmake#37 is merged and released.
So, for a bit of history, you'll need to look at #30 I've been hesitant to change to this because I've long felt that this may end up masking legitimate warnings about improper uses of v8 in your own module. You have to make calls to v8 functions (even if you use NAN, which just abstracts them) in your module code, so I'm not convinced that the headers included here should really be treated as To say this another way, I haven't yet been convinced that #30 suggests a method of doing this locally for your own project if you really need this behaviour. |
It does not mask warnings inside your module, only warnings that occur when parsing the node header file. This is noise and is turned off for all dependency includes in any C++ project. |
This can be removed after cjntaylor/node-cmake#37 is merged and released.
This can be removed after cjntaylor/node-cmake#37 is merged and released.
This will avoid problems were GCC/clang might trigger useless warnings induced by including the
v8
header.