Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update shell scripts #1265

Open
wants to merge 14 commits into
base: crashey
Choose a base branch
from
Open

Update shell scripts #1265

wants to merge 14 commits into from

Commits on Jul 3, 2024

  1. x-prefix in comparisons no longer serves a purpose

    @wiryhatbox
    wiryhatbox committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    94b7545 View commit details
    Browse the repository at this point in the history

  2. x-prefix in comparisons no longer serves a purpose 

    Change shell to sh

Quote variables
    @wiryhatbox
    wiryhatbox committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    f796f9b View commit details
    Browse the repository at this point in the history

  3. Change shell to sh 

    Exit with 1 on failure
    @wiryhatbox
    wiryhatbox committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    cdd35c2 View commit details
    Browse the repository at this point in the history

  4. Make script safer with set -ef 

    Quote variables

More portable

Output all the missing commands instead of just the first

Use either curl or wget with safer parameters

Use end-of-options `--` whenever possible

All commands exit properly on failure

More readable
    @wiryhatbox
    wiryhatbox committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    9d78a16 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. Allow some builds to fail

    @wiryhatbox
    wiryhatbox committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    a6704b1 View commit details
    Browse the repository at this point in the history

  2. More readable 

    More portable

All commands exit properly on failure

Use either curl or wget with safer parameters

Make sure the user can run all commands

Quote variables

Use end-of-options `--` whenever possible
    @wiryhatbox
    wiryhatbox committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    a63974e View commit details
    Browse the repository at this point in the history

  3. Quote variables 

    More portable

All commands exit properly on failure
    @wiryhatbox
    wiryhatbox committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    08aecb2 View commit details
    Browse the repository at this point in the history

  4. Make script safer with set -e 

    Quote variables

More portable
    @wiryhatbox
    wiryhatbox committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    575c549 View commit details
    Browse the repository at this point in the history

  5. Make portable 

    Quote variables

All commands exit properly on failure
    @wiryhatbox
    wiryhatbox committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    a431218 View commit details
    Browse the repository at this point in the history

  6. Make more portable 

    Do not send email by default

x-prefix in comparisons no longer serves a purpose
    @wiryhatbox
    wiryhatbox committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    405cda6 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Quote variables 

    Make script safer with `set -euf`
    @wiryhatbox
    wiryhatbox committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    4225921 View commit details
    Browse the repository at this point in the history

  2. Make script safer with set -e 

    More readable

Quote variables
    @wiryhatbox
    wiryhatbox committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    f86fa74 View commit details
    Browse the repository at this point in the history

  3. Make the lint happy

    @wiryhatbox
    wiryhatbox committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    7ff8b77 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2024

  1. Change permissions of .md files

    @wiryhatbox
    wiryhatbox committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    6eb0f76 View commit details
    Browse the repository at this point in the history