Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Spin locks experiments #715

Merged
merged 1 commit into from
Mar 5, 2019
Merged

More Spin locks experiments #715

merged 1 commit into from
Mar 5, 2019

Conversation

vsonnier
Copy link
Collaborator

@vsonnier vsonnier commented Mar 5, 2019

Contrary to what I said in #713, ThreadBlockingQueue can support SpinMutex through the usage of std::condition_variable_any. Turns out the "sleep or wake" semantic is done through the condition variable not the lock itself.
Lets try this.
Also reverted spin-lock usage in WaterfallCanvas, the operation is not that short-lived, so a proper std::mutex is more fitted there.

@vsonnier vsonnier merged commit c561292 into master Mar 5, 2019
@cjcliffe cjcliffe deleted the vso_spin_lock_adjustments2 branch March 15, 2019 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant