Skip to content
This repository has been archived by the owner on Aug 29, 2020. It is now read-only.

cgo cross-compiling for Darwin #28

Merged
merged 3 commits into from
May 24, 2018
Merged

cgo cross-compiling for Darwin #28

merged 3 commits into from
May 24, 2018

Conversation

f1337
Copy link
Contributor

@f1337 f1337 commented Apr 29, 2018

Relates to (but does not close): #27. Fixes #9.

Restored the Darwin builds & releases. Enabled cross-compiling of cgo via xgo.

See example release here: https://github.com/f1337/gotop/releases/tag/1.2.15

The solution is somewhat hacky, as it expects goreleaser to build Darwin binaries, then re-builds and overwrites them using xgo. Why? So that goreleaser will publish the re-built binaries to github/homebrew/etc.

@cjbassi
Copy link
Owner

cjbassi commented Apr 29, 2018

Thanks for this. 👍 I'll merge it once the other issues are fixed.

@cjbassi cjbassi force-pushed the master branch 5 times, most recently from 9587edb to ee1c57c Compare May 16, 2018 21:55
@f1337
Copy link
Contributor Author

f1337 commented May 23, 2018

With the latest changes to use ps directly instead of gopsutil, I think we can close this PR?

@cjbassi cjbassi merged commit 5878fd0 into cjbassi:master May 24, 2018
@f1337 f1337 deleted the macos branch May 24, 2018 21:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic on Mac caused by cpu percentages issue
2 participants