Add Subnet support #126
Merged
Add Subnet support #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests will fail for time being as API is not ready to receive the requests yet. |
alessandroargentieri
requested changes
Oct 10, 2022
network.go
Outdated
Comment on lines
212
to
232
| func (c *Client) FindSubnet(search, networkID string) (*Subnet, error) { | ||
| subnets, err := c.ListSubnets(networkID) | ||
| if err != nil { | ||
| return nil, decodeError(err) | ||
| } | ||
|
|
||
| exactMatch := false | ||
| partialMatchesCount := 0 | ||
| result := Subnet{} | ||
|
|
||
| for _, value := range subnets { | ||
| if value.Name == search || value.ID == search || value.Label == search { | ||
| exactMatch = true | ||
| result = value | ||
| } else if strings.Contains(value.Name, search) || strings.Contains(value.ID, search) || strings.Contains(value.Label, search) { | ||
| if !exactMatch { | ||
| result = value | ||
| partialMatchesCount++ | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
We have an endpoint to match the exact name: (GET /v2/networks/{networkId}/subnets?name=<exact-name>) so we can use that.
if we want to implement also the partial match I think you can proceed the same way without taking care of the exact match (covered by the previous case I just mentioned), collecting all the matching results and returning them like grep does (instead of returning an error if there are more matches)
|
|
||
| // GetSubnet gets a subnet with ID | ||
| func (c *Client) GetSubnet(networkID, subnetID string) (*Subnet, error) { | ||
| resp, err := c.SendGetRequest(fmt.Sprintf("/v2/networks/%s/subnets/", networkID) + subnetID) |
There was a problem hiding this comment.
you can also do: fmt.Sprintf("/v2/networks/%s/subnets/%s", networkID, subnetID)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds subnet support.