Fix deprecation warnings for permissions array in 5.71 #599
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of CiviCRM 5.71, these warnings appear:
... along with similar warnings about the rest of the permissions.
I've not done any work with Civi extensions, but looking into the URL provided (https://docs.civicrm.org/dev/en/latest/hooks/hook_civicrm_permission/), I believe the issue is related to how the permissions are configured in
CRM/Volunteer/Permission.php
:This array should, I think, be converted to:
etc.. i.e. turn the non-associative array into an associative one with
label
anddescription
keys.This PR does that. 😄 (It also reduces the constant definition of
array('domain' => 'org.civicrm.volunteer')
and just does that once, similar to how the$prefix
variable is used.)