Fix UTC offsets when retrieving timezone string in WordPress #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gah, the old |
|
I did a quick little run. For example creating an activity in the UI defaults the activity date to the wrong time currently, and with the PR sets it according to the configured offset. |
|
jenkins retest this please |
|
Failing Check is unrelated. Have done multiple Will merge once civicrm/civicrm-core#26604 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes this issue on Lab.
Before
In WordPress, one can choose e.g.
UTC+4as the site's timezone. This results in no value being returned byget_option('timezone_string')which may lead to unexpected results in CiviCRM.After
When choosing e.g.
UTC+4in WordPress, a deprecated (but still currently valid)Etc/UTC-4timezone string is used.Comments
There is a companion PR in the CiviCRM-Core repo.