NFC - Update tested up to value for WP sites

[kcristiano]

We've fallen behind by 3 years in updating the tested up to value. PR against the RC as I'd like to see this in 5.57 which is an ESR.

Some hosts and plugins are reporting that CiviCRM only works with WP 5.5 as that is what we declared. I'd like to fix that.

[kcristiano]

jenkins test this please

[kcristiano]

@seamuslee001 Can you take a look at why the tests are failing - I think this is a build failing not a test failing. Am I correct?

[kcristiano]

jenkins test this please

[kcristiano]

jenkins test this please

[kcristiano]

jenkins test this please

[kcristiano]

@seamuslee001 @totten do we know why the NFC change is triggering a failed build?

[totten]

@kcristiano @seamuslee001 - Interesting. In the console output from build 270, this is the only error I see:

Found EXITCODES=""
~/workspace/CiviCRM-WordPress-PR
Check test results and set exit code
Exit normally
[CheckStyle] [-ERROR-] No files found for pattern 'checkstyle/*.xml'. Configuration error?
[CheckStyle] Searching for all files in '/home/jenkins/workspace/CiviCRM-WordPress-PR' that match the pattern 'checkstyle/*.xml'

Jenkins is complaining that it expects to find some output from linting/code-stye checks. But the PR doesn't have any PHP files to check. So that's a plausible cause for the red flag.

The odd thing is that the checkstyle configuration looks the same as elsewhere, and we've never had this before, and we've certainly had NFC PRs changing non-code files. Perhaps there was a plugin-update on Jenkins that the changed behavior for this edge-case? (If this is the issue, you could ignore it. And going forward, we could put a dummy file in.)

(Aside: Just to double-check, @seamuslee001. You all didn't make any changes in the intervening period between Kevin's question and now, right?)

[seamuslee001]

@totten I have done nothing on this job

[totten]

OK, updated job configuration and re-ran test. Looks better now...

[christianwach]

@kcristiano Changes look good to me - except CiviCRM stable is now at 5.57.1 😄 so maybe update, squash and force push?

[kcristiano]

@christianwach I was thinking to make it 5.57, then 5.58, etc. So I'll force push but as this is master we need to make it 5.59 that will make 6.1 for WP

[christianwach]

@kcristiano Agreed. Merging.