Fixes fatal error - function doesn't exist #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per https://developer.wordpress.org/reference/functions/is_favicon/ this function was only added in 5.4.0 meaning CiviCRM now breaks if installed on a site running Wordpress < 5.4.0
|
Can one of the admins verify this patch? |
|
@christianwach any thoughts? Unless we increase the min WP version this makes sense to me and looks good. |
|
Can reproduce on WP 5.3. Fatal error on install. Applying PR fixes the issue. My want to switch branch and target RC. |
|
Is that something that I need to do or is done by whomever is merging in? |
|
Good catch @stesi561 @kcristiano Yes this would be good to merge and backport if possible. |
|
targeting the RC branch as this is a regresion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://developer.wordpress.org/reference/functions/is_favicon/ this function was only added in 5.4.0
meaning CiviCRM now breaks if installed on a site running Wordpress < 5.4.0
Overview
Checks function exists before calling.
Before
Fatal error
After
You should probably upgrade your Wordpress site but if you are stranded on an old version due to plugin/theme incompatibilities at least you don't have a fatal error!
Technical Details