HookTest - Fix execution on PHP 8 #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before ------ Test fails on PHP 8 ``` CiviWP\HookTest::testFoo Undefined array key "hook_was_called" /home/jenkins/bknix-dfl/build/wp-265-47vsb/web/wp-content/plugins/civicrm/tests/phpunit/CiviWP/HookTest.php:22 ``` After ----- Test passes Comments -------- This is a superficial change - the point of the assertion is to validate the starting circumstance (asserting that the hook has not yet run). This is just a cleaner assertion that the hook has not yet run.
|
looks fine to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@seamuslee001 This should address the failure demonstrated by #265.
Before
Test fails on PHP 8
After
Test passes
Comments
This is a superficial change - the assertion in question is supposed to validate the starting circumstance (asserting that the hook has not yet run). This is just a cleaner assertion that the hook has not yet run.