CRM-21812 - don't specify installation type post install

[MegaphoneJon]

The wp-cli-login-server plugin checks for the presence of elements in the $_GET array, and fails if any are found. This conflicts with CiviCRM, which places:

$_GET['civicrm_install_type'] = 'wordpress';

into every page load.

I confirmed that this value is only used for install, and placed a conditional around it to only insert pre-install. I successfully installed CiviCRM and engaged in normal use with the conditional applied, and confirmed that this fixed the WP plugin.

This is intended to close aaemnnosttv/wp-cli-login-command#24.

---

• CRM-21812: WordPress install variable causes conflict with some WP plugins

[christianwach]

FWIW, this is also fixed in #123 as can be seen here.

[kcristiano]

I prefer #123 in favor of this PR. They solve the same issue, but #123 has other benefits as well.

[kcristiano]

@christianwach as #123 needs more testing I think we should merge this now and rebase #123 Any objections?

[christianwach]

@kcristiano No objections here

[MegaphoneJon]

@eileenmcnaughton This has been reviewed by @christianwach and @kcristiano, but I don't think any of us have merge rights. Are you able to merge this for us? Thanks!

[eileenmcnaughton]

Yes