Add hack to support buttonrama without change to code adding submit #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit hacky but I looked at cividiscount & concluded we should support the existing code if we could - if nothing else then to simplify messaging about buttonrama. With this change no change is required to cividiscount (although I did put up another change as it turned out not to work
|
(Standard links)
|
|
I tested this and confirmed it works with the CiviDiscount extension and will assist with the transition merging |
|
thanks @seamuslee001 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit hacky but I looked at cividiscount & concluded we should support the existing
code if we could - if nothing else then to simplify messaging about buttonrama. With this change no change is required
to cividiscount (although I did put up another change to cividiscount which I found to be broken on a different issue civicrm/org.civicrm.module.cividiscount#242)
Without this
With this
Having figured this out I'm not 100% sure it was worth the work I put in :-). However, it does mean that no version specific code is required in extensions. I think only a small handle of extensions are affected (including on by @agh1 who I'm sure knows what to do) - but OTOH the way cividiscount does it is nasty & not having to change that right now feels like a bonus