Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Activate fetchAll function in DataObject file #281

Merged
merged 1 commit into from
Jan 6, 2020

Conversation

seamuslee001
Copy link
Contributor

This depends on civicrm/civicrm-core#16198 to work

ping @eileenmcnaughton

@civibot
Copy link

civibot bot commented Jan 3, 2020

(Standard links)

@seamuslee001
Copy link
Contributor Author

Error is

PHP Warning:  Declaration of CRM_Core_DAO::fetchAll() should be compatible with DB_DataObject::fetchAll($k = false, $v = false, $method = false) in /home/jenkins/bknix-dfl/build/pkg-281-4c2cn/web/sites/all/modules/civicrm/CRM/Core/DAO.php on line 33
PHP Stack trace:
PHP   1. {main}() /home/jenkins/bknix-dfl/build/pkg-281-4c2cn/web/sites/all/modules/civicrm/xml/GenCode.php:0

This PR civicrm/civicrm-core#16198 fixes it

@seamuslee001
Copy link
Contributor Author

Jenkins re test this please

@seamuslee001
Copy link
Contributor Author

@eileenmcnaughton should this be considered MOP now?

@eileenmcnaughton
Copy link
Contributor

yes

@seamuslee001
Copy link
Contributor Author

Test fail unrelated

@seamuslee001 seamuslee001 merged commit fdd23bb into civicrm:master Jan 6, 2020
@seamuslee001 seamuslee001 deleted the parent_fetchall branch January 6, 2020 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants