Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/joomla#16 : [Joomla 4.0] CiviCRM logo not showing in Quick Icon plugin #65

Merged
merged 3 commits into from
May 24, 2022

Conversation

monishdeb
Copy link
Member

BEFORE

before

AFTER

before1

In addition, I have excluded the CiviCRM icon from the Notification and System block.

monishdeb and others added 3 commits May 24, 2022 17:14
a couple of pixels of the repeat were visible at my viewport (which might vary as quickicon uses rem for measurement).
Stops the background icon image repeating.
@vingle
Copy link
Contributor

vingle commented May 24, 2022

This works well for me on J3 & J4. It's a Joomla plugin so doesn't need testing on any other CMS.

@mlutfy
Copy link
Member

mlutfy commented May 24, 2022

Thanks! Merging based on code review, and feedback from Nic.

@mlutfy mlutfy merged commit 768fa88 into civicrm:master May 24, 2022
@monishdeb
Copy link
Member Author

Thank you @mlutfy and @vingle

@monishdeb monishdeb deleted the j4_quickicon_fix branch May 24, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants