Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/core#2258 Define CIVICRM_CRED_KEYS during installation #57

Merged
merged 1 commit into from
Jan 11, 2021
Merged

dev/core#2258 Define CIVICRM_CRED_KEYS during installation #57

merged 1 commit into from
Jan 11, 2021

Conversation

seamuslee001
Copy link
Contributor

Overview

When using running installer, the civicrm.settings.php should have a credential-key.

See also: civicrm/civicrm-core#19349 and https://lab.civicrm.org/dev/core/-/issues/2258

Before

Blank key

After

Random key

@totten

@totten
Copy link
Member

totten commented Jan 11, 2021

Alrighty, it took a while to r-run, but I can confirm that:

  • On new installations, it now generates CRED_KEYS
  • On upgrading (5.27.4=>5.34.alpha1), it regenerates both civicrm.settings.php files and fills in CRED_KEYS on both.
  • On upgrading (5.34.alpha1=>5.34.beta1), it preserves CRED_KEYS on both civicrm.settings.php.

@totten totten merged commit f00f6b8 into civicrm:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seamuslee001 @totten