#13 - Contact Image uploaded from Drupal Webform don't render on Drup…

[jitendrapurohit]

…al View as a thumbnail

Fix for https://lab.civicrm.org/dev/drupal/issues/13

[eileenmcnaughton]

@jackrabbithanna @xurizaemon any opinion on this?

[MegaphoneJon]

• General standards
  • Explain (r-explain)
    • PASS : The goal/problem/solution have been adequately explained with a link (JIRA, Github, Gitlab, * User impact (r-user)
    • PASS: The change would be intuitive or unnoticeable for a majority of users who work with this feature.
  • Documentation (r-doc)
    • PASS: The changes do not require documentation.
  • Run it (r-run)
    • PASS: I applied this patch to an existing database that exhibited this problem (civicrm_contact.image_URL referenced a webform upload directory) and rendered a View which included the image.
• Developer standards
  • Technical impact (r-tech)
    • PASS: The change preserves compatibility with existing callers/code/downstream.
  • Code quality (r-code)
    • PASS: The functionality, purpose, and style of the code seems clear+sensible.
    • COMMENTS: This doesn't support files uploaded in the private file system, but that seems acceptable and out of the current patch's scope.
  • Maintainability (r-maint)
    • UNREVIEWED
    • PASS: The change sufficiently improves test coverage, or the change is trivial enough that it does not require tests.
  • Test results (r-test)
    • PASS: The test results are all-clear.

[eileenmcnaughton]

merging (after ??? 3 years!) based on @MegaphoneJon's review