CRM-20541 - Use drupal_static() instead of static #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The impetus behind CRM-20541 seems to be a testing scenario where the setup/teardown process resets Civi (`Civi::reset()`) without resetting Drupal (`drupal_static_reset()`). IMHO, it's better to keep the systems aligned by either (a) resetting both or (b) resetting neither. For the situation where you reset both, the state within `civicrm_initialize()` needs some way to reset. This function executes within a Drupal context (before Civi has booted), so it should obey the reset conventions for Drupal -- i.e. use `drupal_static()`.
|
I think this seems like real good idea. If you are using CiviCRM Entity, its a heavy user of civicrm_initialize() and things could be happening during cron, in drush, all kinds of processing before and after page loads. Who knows what never before seen conditions could crop up. Better that is in the management of the Drupal static system. |
|
I've patched my local dev instance where I'm working on CiviCRM Entity stuff, and I'll watch and see if anything seems to go amiss. So far works fine (4.6 though), but shouldn't matter really in this case I don't think. |
|
I'm going to merge this - not yet sure if it solves all the test issues I'm having, but I'm pretty sure this is more correct and I don't believe there is any risk with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The impetus behind CRM-20541 seems to be a testing scenario where the
setup/teardown process resets Civi (
Civi::reset()) without resettingDrupal (
drupal_static_reset()). IMHO, it's better to keep the systemsaligned by either (a) resetting both or (b) resetting neither.
For the situation where you reset both, the state within
civicrm_initialize()needs some way to reset. This function executeswithin a Drupal context (before Civi has booted), so it should obey the
reset conventions for Drupal -- i.e. use
drupal_static().Ping @eileenmcnaughton