-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRM-16479: Support for image styles #364
Conversation
JKingsnorth
commented
Mar 18, 2016
- CRM-16479: Support image styles for contact image in Drupal Views
Joe - I can review this PR since will need to merge it for one of my customers. |
Hi @nganivet did you get the chance to review this PR? |
John, yes reviewed the code and all seems good. It is also installed on ------ Original Message ------
|
Great news, thanks for testing. Can you comment on the JIRA issue too with
|
Is there supposed to be an interface for this in Views? The code looks like it provides one, but I'm not seeing it. I'm using Drupal 7.52 and CiviCRM 4.7.13, and have installed both the CiviCRM Entities (CiviCRM Entity Views Extras is enabled) and Picture modules. Attached is a screenshot of the Views dialog I get for the CiviCRM Contacts: Contact Image field. Please advise. If there's a better place to post a question about this, let me know where. Thanks. |
Hi @houblon . The 'Image' module will also need to be enabled. And the CiviCRM images will need to be in the 'public://' files directory in Drupal. The functionality is enabled if 'Image' is enabled, and it can find the right directory (which is handled by this function: https://github.com/civicrm/civicrm-drupal/pull/364/files#diff-141bb1408c66b6d40a72bf7ad9fba3ecR145) |
Hi @JKingsnorth . Thanks for the quick reply. I verified that the Image module is enabled (it is; the Picture module requires it), and changed the path settings in the Upload Directories settings of CiviCRM (see attached screenshot), unfortunately with no effect on the Views dialog for the CiviCRM Contacts: Contact Image field. I verified that images uploaded through the CiviCRM contact edit form are uploaded to Drupal's 'public://' files directory. I also tried changing the CiviCRM Resource URLs path for Image Upload URL to the 'public://' files directory path, but that also didn't have a noticeable effect, and I got an warning that this path shouldn't publicly accessible, so I figure this isn't the path to change. Is there something else I need to do? Also, for CiviCRM images, is it possible to specify a subdirectory of Drupal's 'public://' files directory? |
Works for me using the patched civicrm_handler_field_contact_image.inc |
@JKingsnorth, I figured it out. I'm using the "CiviCRM 4.7.13 for Drupal 7.x" download from https://civicrm.org/download/list and didn't realize it doesn't include the latest updates for file civicrm_handler_field_contact_image.inc (thanks, @magnolia61, for mentioning that it's currently a patch) . Thanks very much for this functionality; it's working now on my site. As @magnolia61 asked, will this be included in the 4.7.14 release, or should I plan to patch this file for that release? |
If you're asking about the patch from this PR, yes it has been merged and will be included in the next release. |