Add back in body classes for themeing. #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds back in the `page-civicrm` style body classes missing from Drupal 8 and Drupal 9 but present in Drupal 7. This allows themes that rely on those classes like Shoreditch to maintain functionality on Drupal 8 and 9 much easier.
|
@sunilpawar As someone who has been pretty active in these areas, any thoughts on this PR? |
|
@mlutfy tested functionality using Before : Vertical tab not present |
|
Thanks @sunilpawar ! I will leave open a few days in case anyone has objections. It was also discussed on the chat: https://chat.civicrm.org/civicrm/pl/j19dch5qhbgi7egckp9xs3hswo (Drupal channel) |
This was referenced Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds back in the
page-civicrmstyle body classes missing from Drupal 8 and Drupal 9 but present in Drupal 7.This allows themes that rely on those classes like Shoreditch to maintain functionality on Drupal 8 and 9 much easier.