Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CiviCRM Standalone #12

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Conversation

mlutfy
Copy link
Member

@mlutfy mlutfy commented Aug 29, 2023

Related to (merged) civicrm/civicrm-core#27104

Has been tested in prod already.

I'm not really sure why it shows for Nightly and not the RC (stable uses different code). I mostly copy-pasted what I could. (and stable builds are 404 for now, but they should soon show up, right?)

@@ -200,6 +203,7 @@ protected function getLatestStable() {
'[email protected]' => array('commit' => "6.x-$rev"),
'[email protected]' => array('commit' => "7.x-$rev"),
'[email protected]' => array('commit' => "8.x-$rev"),
'civicrm-standalone' => array('commit' => $rev),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The git array defines the commits/tags that correspond to the code for a particular build. We're not actually tagging civicrm-standalone.git (and it's not used as part of that build).

I'm not sure that tags should be sync'd, since civicrm-standalone.git is more like a project-template rather than a library that one depends on. If we don't do those tags, then we shouldn't have this line.

But if you think there's a reason why we should, then this should be here. (But there are probably some other bits that will be required for that.)

@totten
Copy link
Member

totten commented Aug 30, 2023

If it's working in prod, then that's good. Probably better to merge unless there's a major problem (since that makes master more accurate). I'm not currently able to run it locally... (My oldest available version of php is 7.4...)

I'm not really sure why it shows for Nightly and not the RC (stable uses different code)

Perhaps because the distmaker updates (civicrm-core#27104) are only in master? The current 5.65-rc doesn't include it, so distmaker won't make it.

I mostly copy-pasted what I could.

👍

(and stable builds are 404 for now, but they should soon show up, right?)

Makes sense, for the same reason as RC. They won't appear until 5.66-master becomes 5.66-stable (unless one specifically ports civicrm-core#27104). +1 month doesn't feel "soon" right now, but it is "soon" in the grand scheme of things...

We can keep an eye after freezing for 5.66-rc in the next week. If that fixes RC, then it's reasonable to expect STABLE to will also sort out.

@totten totten merged commit 48a1353 into civicrm:master Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants