CRM-20145 line_item $0 entity_financial_trxn fix #9866
Conversation
lcdservices
commented
Feb 21, 2017
•
lcdservices
commented
- CRM-20145: line_item with $0 amount may error when creating civicrm_entity_financial_trxn
CRM/Contribute/BAO/Contribution.php
Outdated
| @@ -5418,7 +5418,8 @@ public static function getSalesTaxFinancialAccounts() { | |||
| public static function createProportionalEntry($entityParams, $eftParams) { | |||
| $paid = $entityParams['line_item_amount'] * ($entityParams['trxn_total_amount'] / $entityParams['contribution_total_amount']); | |||
| // Record Entity Financial Trxn | |||
| $eftParams['amount'] = round($paid, 2); | |||
| // CRM-20145 | |||
| $eftParams['amount'] = number_format((float)round($paid, 2), 2, '.', ''); | |||
There was a problem hiding this comment.
@lcdservices could we make this into a tiny utility function that can be used wherever we are about to store a money value in db? Currently we should always be storing 2 digits after the decimal in core, but cryptocurrencies will need more. @pradpnayak could you ensure we create/use the same utility function throughout work on sales taxes?
There was a problem hiding this comment.
I've updated the PR accordingly.
|
@KarinG since you have had your head deep into this code can you comment as to whether you have any reason to think this should, or shouldn't be merged? |
|
Actually - @eileenmcnaughton sorry... I've not been here yet... To be frank: I'm not sure what proportional (as opposed to non-proportional ones?) financial transactions represent in terms of sales taxes - or which kind is needed when? Eh... I find eftParams very confusing - EFT in financial language is always used for Electronic Funds Transfer - and pretty sure that's not what's going on here. However if @lcdservices says this (whatever this is) is working for him if with this edit - then let's just get this in for him? Ok - I've got to get back to my own corporate Sales Tax return - due tomorrow - for real :-) |
|
Well I think that is a blessing from Karin (of sorts) - still need the style issues resolved |
|
@eileenmcnaughton style issues are fixed. |
CRM-20145 line_item $0 entity_financial_trxn fix
