[NFC] Date metadata fixes towards CRM-19490, CRM-18387, CRM-20012, CRM-20011, CRM-15948, CRM-19911 #9845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance the information available about dates. Based on the date format a format string in php and in 'our posix' should be returned. (as long as we set the context to 'input' our of cautiousness. min & max year should be calculated for all types, not just credit cards
The importable fields function is not returning all possibly useful fields, it is filtering them by criteria that are a bit unreliable. They are not being used here for filtering so we should get the full library in all cases.
…e profile fields. This is further NFC change towards CRM-19840 and a range of other date fixes. It ensures that date data is available on date fields allowing us to reduce code elsewhere
seamuslee001
approved these changes
Feb 16, 2017
|
Yes, all these have been in the larger PR we have been testing - it's just that I'm trying to figure out how to keep the change as safe as possible & hence trying to change the metadata first & then work through the flow-on field changes. |
|
My feeling is that as long as this passes tests then i think its ok to move forward with. |
|
done! |
monishdeb
pushed a commit
to monishdeb/civicrm-core
that referenced
this pull request
May 2, 2017
[NFC] Date metadata fixes towards CRM-19490, CRM-18387, CRM-20012, CRM-20011, CRM-15948, CRM-19911
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits are the NFC changes towards a bunch of date issues. Basically most of the problems go away once we swap custom handling for metadata-based date picker fields. Date picker fields use only ISO data format at the php level so a lot of non-robust custom data handling can go - & with it a bunch of problems.
This patch simply works to make the metadata available for the switch. I am trying to make the actual switch in a bunch of small changes in order to try to find any gotchas