CRM-19934 improvement on acl cache. #9807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change means that when we are checking the allow function we do not add the harmful OR to the query. The 'view my contact' & 'edit my contact' permissions have already been checked for. Adding them into the ACL query with an OR causes serious performance issues, as elsewhere commented. We can & should avoid it here
|
@systopia Bjorn, this is a pretty minor change - I'm hoping you remember the code well enough to review & approve it |
No, sorry :-/ I can't even remember what these parameters do. If you want, I could dig into that, but it'll be a while - I'm really swamped atm. |
|
The last one has changed - it sets 'do not add the view my contact part on because we've already checked that here & it's really really slow & sucky' |
seamuslee001
approved these changes
Feb 16, 2017
|
thanks for the review @seamuslee001 |
monishdeb
pushed a commit
to monishdeb/civicrm-core
that referenced
this pull request
May 2, 2017
CRM-19934 improvement on acl cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change means that when we are checking the allow function we do not add the harmful
OR to the query.
The 'view my contact' & 'edit my contact' permissions have already been checked for.
Adding them into the ACL query with an OR causes serious performance issues, as
elsewhere commented. We can & should avoid it here