Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

civicrm_webtest.install - Restore access to edit message templates and tags #9785

Merged
merged 2 commits into from
Feb 7, 2017

Conversation

totten
Copy link
Member

@totten totten commented Feb 4, 2017

This affects demo builds and (theoretically) other test systems.

This affects demo builds and (theoretically) other test systems.
@seamuslee001
Copy link
Contributor

@totten should we add in manage tags permission?

This affects demo builds and (theoretically) other test systems.
@totten totten changed the title civicrm_webtest.install - Restore access to edit message templates civicrm_webtest.install - Restore access to edit message templates and tags Feb 5, 2017
@totten
Copy link
Member Author

totten commented Feb 6, 2017

@seamuslee001 Yeah, both of those seem like issues where the test/demo system got left behind. :( Thanks.

Aside: Grepping on these, it's interesting to note that there was an upgrade alert for edit message templates (encouraging downstream admins to update their permission settings) -- but manage tags didn't have an alert. That's the kind of gotcha we need to handle better as reviewers.

@seamuslee001
Copy link
Contributor

Agree @totten do you think we should add in a post upgrade message for the manage tags?

@seamuslee001
Copy link
Contributor

Jenkins test this please

@totten totten merged commit 573c2c3 into civicrm:master Feb 7, 2017
@totten totten deleted the master-perm-msgtpl branch February 7, 2017 23:31
monishdeb pushed a commit to monishdeb/civicrm-core that referenced this pull request May 2, 2017
civicrm_webtest.install - Restore access to edit message templates and tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants