Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-19960 Hide page title when is supposed to be removed #9770

Merged
merged 1 commit into from
Feb 18, 2017

Conversation

seamuslee001
Copy link
Contributor

@seamuslee001 seamuslee001 commented Feb 2, 2017

@colemanw
Copy link
Member

colemanw commented Feb 4, 2017

Can you explain what's happening? Is the html getting escaped so that we literally see the <span id="crm-remove-title" ... as the page title?

@seamuslee001
Copy link
Contributor Author

@colemanw that is correct in D8 it is treating it as a plain string as per https://api.drupal.org/api/drupal/core!modules!node!src!Entity!Node.php/function/Node%3A%3AsetTitle/8.2.x

@jackrabbithanna
Copy link
Contributor

@seamuslee001 @eileenmcnaughton

I've tested this and it works for me. I recommend merging

Copy link
Contributor

@jackrabbithanna jackrabbithanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me, its good to go

@eileenmcnaughton eileenmcnaughton merged commit d096df1 into civicrm:master Feb 18, 2017
monishdeb pushed a commit to monishdeb/civicrm-core that referenced this pull request May 2, 2017
CRM-19960 Hide page title when is supposed to be removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants