Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM_Extension_Browser - Allow different cache files for different feeds #9693

Merged
merged 1 commit into from
Jan 18, 2017

Conversation

totten
Copy link
Member

@totten totten commented Jan 17, 2017

The motivation here is to support these two different CLI commands:

cv dl myextension
cv dl myextension --dev

The two commands differ in that they pull from different feeds -- e.g. the
stable feed https://civicrm.org/extdir/ver={ver}|cms={uf} vs the
developmental feed https://civicrm.org/extdir/ver={ver}|cms={uf}|status=.
However, this creates the real possibility that the user might go back/forth
among different feeds (omitting/enabling the --dev option per whim).

The motivation here is to support these two different CLI commands:

```
cv dl myextension
cv dl myextension --dev
```

The two commands differ in that they pull from different feeds -- e.g.  the
stable feed `https://civicrm.org/extdir/ver={ver}|cms={uf}` vs the
developmental feed `https://civicrm.org/extdir/ver={ver}|cms={uf}|status=`.
However, this creates the real possibility that the user might go back/forth
among different feeds (omitting/enabling the `--dev` option per whim).
@totten totten force-pushed the master-browser-cache branch from 9a853a8 to 5bcef2c Compare January 17, 2017 23:37
@totten
Copy link
Member Author

totten commented Jan 17, 2017

Updated and squashed patch.

Jenkins reported a failure reading the newly named test file. This is odd because:

  1. The failure makes sense with old code and new code.
  2. The failure doesn't reproduce locally (even if I clear out cache files before running it).

Theory: the code was buggy before, but it was obscured because (a) error-reporting is not consistent across PHP configs and (b) something in the test-suite (preceding test) has a side-effect which was producing that file. (Specifically, api_v3_ExtensionTest in 4.7 plays around with ext_repo_url.)

We'll see if the revised patch (with proper guard) fixes it.

@colemanw
Copy link
Member

Makes sense to me.

@colemanw colemanw merged commit b08ff38 into civicrm:master Jan 18, 2017
@totten totten deleted the master-browser-cache branch January 18, 2017 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants