CRM-19636, fixed db error for Top Donor report when filtered using Co… #9375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does using $this->getBasicContactFilters() work? |
|
@pradpnayak can you bring the changes suggested by Eileen ? |
|
getBasicContactFilters() has extra filters compared to contact filters defined in Top Donor report(9 extra). Is it fine to add additional contact filters on this report? |
pradpnayak
force-pushed
the
CRM-19636
branch
from
6cda5e0 to
ff1b50d
Compare
|
I think so - unless one of them doesn't work. It confuses people when the filters vary by report |
…ntact Name, Contact sub type, Contact type etc ---------------------------------------- * CRM-19636: DB error on Top Donor Report https://issues.civicrm.org/jira/browse/CRM-19636
---------------------------------------- * CRM-19636: DB error on Top Donor Report https://issues.civicrm.org/jira/browse/CRM-19636
pradpnayak
force-pushed
the
CRM-19636
branch
from
ff1b50d to
bef8d64
Compare
|
@eileenmcnaughton , @monishdeb i have added the changes. |
|
Ok, reviewing |
|
Works fine, tested with contact filters w/o group by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ntact Name, Contact sub type, Contact type etc
https://issues.civicrm.org/jira/browse/CRM-19636