Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-19569 - use relative links from info page to registration page. #9324

Merged
merged 1 commit into from
Oct 28, 2016

Conversation

jmcclelland
Copy link
Contributor

@jmcclelland jmcclelland commented Oct 26, 2016

@colemanw
Copy link
Member

How well would this work when displaying the event info in an external site? Does it affect feeds?

@jmcclelland
Copy link
Contributor Author

All good questions...

The changes should only apply to the event info page itself - it should not apply to the feeds or any other place where event links are created.

If you are displaying the Event Info page via an iframe on a different site, the relatively URLs will still be relative to the iframe source, not the parent, so they should continue work.

If you are using a method to grab the generated content from the Event Info page and display it on another site, then we would have a problem. However, I'm not aware of any method that would make this kind of display feasible.

Additionally, the Event Info page already has some relative links (the breadcrumb and the link to register another participant if you have already registered).

@colemanw colemanw merged commit 88169e0 into civicrm:master Oct 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants