[ready-for-core-team-review]CRM-19485, Fixed selector issue on Batch Transaction form #9211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested successfully and reviewed code. Ready to merge. |
colemanw
requested changes
Oct 12, 2016
| "url": sSource, | ||
| "data": aoData, | ||
| "success": fnCallback | ||
| }); | ||
| } | ||
| }); | ||
| toggleFinancialSelections('#toggleSelect', 'assign'); |
There was a problem hiding this comment.
Disabling async in ajax calls is deprecated.
Add this call to your fnCallback instead and you don't need to do so. Like this:
"success": function() {
toggleFinancialSelections('#toggleSelect', 'assign');
fnCallback();
}
| "success": fnCallback | ||
| }); | ||
| } | ||
| }); | ||
| toggleFinancialSelections('#toggleSelects', 'remove'); |
| @@ -172,6 +163,19 @@ function enableActions( type ) { | |||
| } | |||
| } | |||
|
|
|||
| function toggleFinancialSelections(toggleID, toggleClass) { | |||
| mark = 'x'; | |||
| @@ -52,6 +52,7 @@ | |||
| {else} | |||
| <td> </td> | |||
| {/if} | |||
| </tr> | |||
There was a problem hiding this comment.
Yes, it was missing
---------------------------------------- * CRM-19485: Selector issue on Batch trxn assignment page https://issues.civicrm.org/jira/browse/CRM-19485
…ion for toggling in success ---------------------------------------- * CRM-19485: Selector issue on Batch trxn assignment page https://issues.civicrm.org/jira/browse/CRM-19485
|
@colemanw thanks for the alternate solution for async. I have updated the PR with the changes. Could you please review? |
colemanw
approved these changes
Oct 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.civicrm.org/jira/browse/CRM-19485