[REF] Fix empty label accessibility issue on report elements

[monishdeb]

Overview

Fixes accessibility issues on report elements.
Before

1. Empty form label on report text element:

2. Empty form label in page break and group by:

3. Empty form label on actions and add contact to group widgets:

After

Fixed them all

Technical Details

Dependent on colemanw/select2#5

Comments

ping @seamuslee001 @colemanw

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[vingle]

test this please

[vingle]

1 + 2 definitely work and are big accessibility fixes. 3 I think is the one that needs the Select2 fix to go thru first as it wasn't working for me.

I also noticed another empty table header in the first column linked to item 2 (but that's more a new issue than problem with this PR):

[monishdeb]

hey @vingle would you give another try to #3 now when the colemanw/select2#6 is merged ?

[vingle]

test this please

[vingle]

@monishdeb

I don't know which Reports this PR is referring to but the first I tried gave me an empty label and empty button error:

[monishdeb]

@vingle for #3 the patch doesn't target any specific report but fixes the absence of label to 'Add Contacts to Group' dropdown by adding a title to select2 dropdown 'Add Contacts to Group'.

In this example I am using contribution detail report.

1. https://dmaster.demo.civicrm.org/civicrm/report/instance/8 ( demo / demo )
   Before:

2. http://core-30694-1kk8w.test-1.civicrm.org:8003/civicrm/report/instance/8 - demo site (demo / demo)
   After:

[monishdeb]

Similarly this patch fixes :

• for item 1, empty label of input text elements as report filters for all reports
• for item 2, empty label to page break / group by checkboxes in all reports

[vingle]

Ah I see, thanks - the two issues I flagged weren't targetted in this PR. But the issue that was - missing label for the add to contact select2, was.

So yes, good to merge from my side.

[monishdeb]

Yeah I agree, those are separate issues but good to have them fixed and I'll submit a new PR.

Thank you for your feedback :)