avoid deprecation notice if header is null #29901
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I'm getting errors like the following:
Before
When
$form->_columnHeaders[$header]
is defined but$form->_columnHeaders[$header]['title']
is not defined or null, then we end up passing NULL to thestrip_tags
function, which expects a string.After
By coalescing
$form->_columnHeaders[$header]['title']
to a empty string when NULL, we avoid this error.