dev/core#5071 Use first pricefield ID when inferring membership type

[agileware-fj]

Use first pricefield ID when inferring membership type ID from checkboxes

Overview

Prevents a crash on Contribution pages for membership sign up when you try to add a checkboxes price fields and assign a default that doesn't link to a membership type
See dev/core#5071

Before

TypeError fatal when loading contribution pages as described, as it's trying to use an array to as an ID.

After

Uses the first key of the array as the relevant ID to load a membership type from the database

Comments

This code actually feels like a redundant way to confirm that the PriceFieldValue doesn't link to a membership type ID anyway, so a better solution might be to just remove the line causing the crash entirely.

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[civibot]

The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/5071

[eileenmcnaughton]

@agileware-fj on latest master it looks like $memTypeID is unused - can we just remove that line? (those 2 lines actually cos it happens twice)

[eileenmcnaughton]

I changed the branch to 5.72 as we have very recent changes in this code (including the change that made that variable unused) so I think the rc is more appropriate than master

[agileware-fj]

@eileenmcnaughton That's the line that I was suggesting would make sense to remove because I'm not sure it even did anything useful before.

Resubmitted as just its removal against 5.72.

[eileenmcnaughton]

thanks @agileware-fj - I'm thinking we should include in 5.71.1?