[NFC] test fix for leap year

[demeritcowboy]

Overview

test fails on Feb 26 in leap years.

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[eileenmcnaughton]

I believe in fact the tests fail on Feb 27 on leap years....

[demeritcowboy]

Oh yes, probably every day between feb 26 and feb 28. Ok let me get my time machine and rejig.

[demeritcowboy]

The feb 29 I couldn't do in my head. But it can be confirmed by seeing that:

php -r "echo date('Y-m-d', strtotime('2024-02-29 - 2 year + 3 day'));" gives 2022-03-04

and

SELECT DATEDIFF(
        IF(
            DATE(CONCAT(YEAR('2024-02-29'), '-', MONTH('2022-03-04'), '-', DAY('2022-03-04'))) < '2024-02-29',
            CONCAT(YEAR('2024-02-29') + 1, '-', MONTH('2022-03-04'), '-', DAY('2022-03-04')),
            CONCAT(YEAR('2024-02-29'), '-', MONTH('2022-03-04'), '-', DAY('2022-03-04'))
        ),
        '2024-02-29'
    );

returns 4

[demeritcowboy]

Ah I should put this against 5.71, otherwise tests on backports will fail for a few days.

[eileenmcnaughton]

Happy 29th of Feb

[demeritcowboy]

I still can't get over how you're living in the future.

I think I'm going to propose to the [insert whatever org controls time] that individual regions be allowed to regulate if they want leap years, since our time systems are too simple with just timezones and DST.

[eileenmcnaughton]

shame it doesn't allow me to tell you who will win lotto