Remove calls to get_template_vars, template_exists

[eileenmcnaughton]

Overview

Remove calls to get_template_vars, deprecate more noisily

Before

A couple of places called by gencode still handling possibility Smarty2 is loaded directly & that getTemplateVars() might not be available - but we since hacked Smarty2 so it IS always available

After

Hacks removed, noisy deprecation added

Technical Details

Comments

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[seamuslee001]

Test fail relates

2024-02-15 15:56:19-0800  [warning] Deprecated function CRM_Core_SmartyCompatibility::get_template_vars, use getTemplateVars.
CRM_Core_Error::deprecatedFunctionWarning
CRM_Core_SmartyCompatibility::get_template_vars
Smarty::getTemplateVars
::smarty_block_crmScope
Array
(
    [civi.tag] => deprecated
)

[eileenmcnaughton]

@seamuslee001 I can't quite see where that is coming from but I'll add the noise as a follow up

[eileenmcnaughton]

I switched this to 5.71 on the basis that that works with Smartty 4 - & Smarty4 + this are key parts of supporting php 8.3