Add str_starts_with modifier to Smarty

[eileenmcnaughton]

Overview

Add str_starts_with modifier to Smarty

Using str_starts_with like this will work on Smarty2 / 3 already but needs this to work on Smarty4 / Smarty5 without notices

Before

We use |substr in a handful of places in the template layer in core & contact layout editor. It is used in this way in all cases... (ie looking for str_starts_with). In Smarty4 all php functions must be registered or notices will appear

After

You can tell it's working cos we get brand new notices when we display the form with phone & im

Technical Details

@colemanw definitely prefers str_starts_with over substr....

Comments

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[eileenmcnaughton]

I just pushed up the notice fix - you can see home address has a both for extension

[eileenmcnaughton]

I REALLY doubt anyone uses the IM field - but I got another notice on confirm with it.... so I fixed that

[eileenmcnaughton]

And one last notice on ThankYou

[colemanw]

@eileenmcnaughton does this mean the contact layout editor needs to be updated?

[eileenmcnaughton]

@colemanw yep - but it can be updated even before this patch is merged - str_contains_str will already work in Smarty 2 & 3 (& noisily in 4)