Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMS tasks, use shared trait, move some functions to it #29285

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

eileenmcnaughton
Copy link
Contributor

This just moves 2 functions that are the same over (changing one to be use the token processor as including domain tokens is good)

I will move other functions from the static class to the trait in follow ups

This just moves 2 functions that are the same over (changing one to be use the
token processor as including domain tokens is good)

I will move other functions from the static class to the trait in follow ups
Copy link

civibot bot commented Feb 6, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Feb 6, 2024
@eileenmcnaughton
Copy link
Contributor Author

ok test fail is cos the gencode one needs to be merged & then I need to do a small follow up to unbreak again if running Smarty2

@eileenmcnaughton
Copy link
Contributor Author

test this please

@colemanw colemanw merged commit f2ffb8d into civicrm:master Feb 8, 2024
3 checks passed
@colemanw colemanw deleted the sms_trait branch February 8, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants