Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notices & php8.2 compatibility on Manage Event Info page #29240

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Fix notices & php8.2 compatibility on Manage Event Info page

Before

Form calling complex non-php8.2 compliant function

After

Form calling simple function - as the fields are loaded by ajax

Technical Details

I tested with a type-specific field & it did save it OK. I also fixed the parent to use the event trait

Comments

Copy link

civibot bot commented Feb 4, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Feb 4, 2024
@@ -124,7 +124,7 @@
</tr>
{/if}
</table>
{include file="CRM/common/customDataBlock.tpl" entityID=$eventID}
{include file="CRM/common/customDataBlock.tpl" entityID=$eventID cid=false}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cid only needed for entities with more than one possible contact ID (activities)

@eileenmcnaughton
Copy link
Contributor Author

test this please

@colemanw colemanw merged commit 41a6aa7 into civicrm:master Feb 5, 2024
3 checks passed
@colemanw colemanw deleted the manage_event_info branch February 5, 2024 02:42
@eileenmcnaughton
Copy link
Contributor Author

This seems to have fixed a bug with handling file fields as a by product

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants