Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#4960 Make Case menu link in relationship tab conditional #29200

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

ejegg
Copy link
Contributor

@ejegg ejegg commented Feb 2, 2024

Only add the link when CiviCase is enabled

Fixes: https://lab.civicrm.org/dev/core/-/issues/4960

Overview

Fix a regression stopping the Relationship tab from loading active relationships when CiviCase not active

Before

On 5.70, deactivate CiviCase and load the relationship tab of a contact with active relationships. The active relationships do not load and an ajax call returns with http status 500

After

Relationship tab loads normally whether CiviCase is active or not

Copy link

civibot bot commented Feb 2, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Feb 2, 2024
@ejegg ejegg force-pushed the conditionalCaseLink branch 2 times, most recently from fd1c70c to b01f44c Compare February 2, 2024 16:09
@colemanw
Copy link
Member

colemanw commented Feb 2, 2024

Thanks @ejegg can you rebase this for the 5.70 branch?

Only add the link when CiviCase is enabled

dev/core#4960
@ejegg ejegg force-pushed the conditionalCaseLink branch from b01f44c to e1da88a Compare February 2, 2024 16:25
@ejegg ejegg changed the base branch from master to 5.70 February 2, 2024 16:27
@civibot civibot bot added 5.70 and removed master labels Feb 2, 2024
@ejegg
Copy link
Contributor Author

ejegg commented Feb 2, 2024

OK, I think that's rebased it @colemanw

@colemanw
Copy link
Member

colemanw commented Feb 2, 2024

Looks perfect! Thanks @ejegg

@ejegg
Copy link
Contributor Author

ejegg commented Feb 2, 2024

Seems like an unrelated test fail: api_v3_ContributionTest.testSendConfirmationPayLater

@colemanw
Copy link
Member

colemanw commented Feb 2, 2024

Our test infra is having a bad day.

@colemanw
Copy link
Member

colemanw commented Feb 2, 2024

@civicrm-builder retest this please

@eileenmcnaughton eileenmcnaughton changed the title Make Case menu link in relationship tab conditional dev/core#4960 Make Case menu link in relationship tab conditional Feb 2, 2024
@colemanw
Copy link
Member

colemanw commented Feb 2, 2024

retest this please

@colemanw colemanw merged commit b35dd0d into civicrm:5.70 Feb 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants