-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev/core#4960 Make Case menu link in relationship tab conditional #29200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
fd1c70c
to
b01f44c
Compare
Thanks @ejegg can you rebase this for the 5.70 branch? |
Only add the link when CiviCase is enabled dev/core#4960
b01f44c
to
e1da88a
Compare
OK, I think that's rebased it @colemanw |
Looks perfect! Thanks @ejegg |
Seems like an unrelated test fail: api_v3_ContributionTest.testSendConfirmationPayLater |
Our test infra is having a bad day. |
@civicrm-builder retest this please |
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only add the link when CiviCase is enabled
Fixes: https://lab.civicrm.org/dev/core/-/issues/4960
Overview
Fix a regression stopping the Relationship tab from loading active relationships when CiviCase not active
Before
On 5.70, deactivate CiviCase and load the relationship tab of a contact with active relationships. The active relationships do not load and an ajax call returns with http status 500
After
Relationship tab loads normally whether CiviCase is active or not