dev/core#4951 Add support for smarty debugging #29183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
|
The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/4951 |
seamuslee001
reviewed
Feb 1, 2024
CRM/Utils/String.php
Outdated
| @@ -1034,6 +1034,11 @@ public static function parseOneOffStringThroughSmarty($templateString) { | |||
| $cachingValue = $smarty->caching; | |||
| set_error_handler([$smarty, 'handleSmartyError'], E_USER_ERROR); | |||
| $smarty->caching = 0; | |||
| if (CRM_Utils_Constant::value('SMARTY_DEBUG_STRINGS')) { | |||
There was a problem hiding this comment.
@eileenmcnaughton do we need a specific one for smarty here why not just like the general debugging flag?
There was a problem hiding this comment.
@seamuslee001 yeah could do - it could get pretty noisy?
eileenmcnaughton
force-pushed
the
smarty_debug
branch
from
1724585 to
ad3006a
Compare
eileenmcnaughton
force-pushed
the
smarty_debug
branch
from
ad3006a to
6cb5804
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Note this is called all the time so I just did a quick check that message templates still render - but in fact all these changes came out of my efforts to get Smarty3 tests passing so have been put through the test ringer