dev/core#4836 Fix mishandling of multiple fields with serialize

[eileenmcnaughton]

Overview

dev/core#4836 Fix mishandling of multiple fields with serialize

Before

See https://lab.civicrm.org/dev/core/-/issues/4836

After

Fixed

Technical Details

Comments

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[civibot]

The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/4836

[eileenmcnaughton]

@colemanw if you feel like tackling

civicrm-core/CRM/Core/BAO/CustomValueTable.php

Line 606 in b25c769

$sql = "

this unit test goes through that code so could cover any changes

Also, I tried going a step further on this & switching to apiv4 but it is failing Authorization even though we aren't mocking a logged in user - that sorta makes sense but I thought tests were chill about checking permissions in that scenario

edad583

[Detsieber]

(CiviCRM Review Template WORD-1.2)

• General standards
  • (r-explain) Pass
  • (r-user) _Pass: Bugfix, now works as expected
  • (r-doc) Pass
  • (r-run) Pass: Test for different combinations of multivalue and normal fields
• Developer standards
  • (r-tech) Pass: Bugfix
  • (r-code) Undecided
  • (r-maint) Pass
  • (r-test) Pass

[colemanw]

@eileenmcnaughton Ok. #29124